Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

provider/aws: Allow changing of S3 Bucket ACL without forcing new bucket #4080

Merged
merged 1 commit into from
Nov 27, 2015
Merged

provider/aws: Allow changing of S3 Bucket ACL without forcing new bucket #4080

merged 1 commit into from
Nov 27, 2015

Conversation

stack72
Copy link
Contributor

@stack72 stack72 commented Nov 26, 2015

Fixes #3135
Changing the S3 Bucket resource to allow the update of ACL by using PutBucketAcl

make testacc TEST=./builtin/providers/aws TESTARGS='-run=S3Bucket_UpdateAcl' 2>~/tf.log
go generate ./...
TF_ACC=1 go test ./builtin/providers/aws -v -run=S3Bucket_UpdateAcl -timeout 90m
=== RUN   TestAccAWSS3Bucket_UpdateAcl
--- PASS: TestAccAWSS3Bucket_UpdateAcl (24.91s)
PASS
ok      github.com/hashicorp/terraform/builtin/providers/aws    24.924s

@stack72 stack72 mentioned this pull request Nov 26, 2015
Closed
@jen20
Copy link
Contributor

jen20 commented Nov 27, 2015

LGTM. Thanks @stack72!

jen20 added a commit that referenced this pull request Nov 27, 2015
@jen20
Merge pull request #4080 from stack72/f-aws-s3-bucket-acl-update
915d307 
provider/aws: Allow changing of S3 Bucket ACL without forcing new bucket
@jen20 jen20 merged commit 915d307 into hashicorp:master Nov 27, 2015
@ghost
Copy link

ghost commented Apr 29, 2020

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.

If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@ghost ghost locked and limited conversation to collaborators Apr 29, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement provider/aws
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Changing ACL on an S3 bucket should not require recreating the bucket
2 participants
@stack72 @jen20